Enable cling based emscripten build #739
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 79.83% 79.39% -0.45%
==========================================
Files 9 9
Lines 3963 3780 -183
==========================================
- Hits 3164 3001 -163
+ Misses 799 779 -20 see 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I don't think we should support a cling based emscripten build. We will unnecessarily be increasing our maintenance workload. Also, ROOT themselves are trying to move many LLVM patches upstream. And Cling is not actively developed like clang-repl. |
|
+1 I don't see a good reason behind doing this. P.S: In my PyData Paris last month, I just educated people to move away from xeus-cling and use xeus-cpp because of how actively it is being developed and people can raise bugs and get them addressed. So I don't think I would be someone contributing to any effort or maintainance if this goes in :\ |
|
I had a discussion with Vassil about this. And Vassil pointed out some reasons to try and pursue this. Mainly, this can potentially enable running the ROOT tutorials within the browser. I agree with this reasoning. @mcbarton, I guess you can continue efforts to enable this. But let's explicitly specify that this is experimental. And work on this should not block anything else. |
3 participants
Description
Please include a summary of changes, motivation and context for this PR.
If you build roots llvm 20 against cling master with the changes in root-project/root#20231, then you can cross compile a CppInterOp which makes use of cling to wasm using Emscripten. CppInterOps Emscripten tests can build, but the tests fail immediately due to a popen error here in cling https://github.com/root-project/cling/blob/903295516f19014a0097bfd516cb23295ef1a404/lib/Interpreter/CIFactory.cpp#L160
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist